Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#35: check if the title in GuaranteedAnalysis is minimal #47

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Issue#35: check if the title in GuaranteedAnalysis is minimal #47

merged 8 commits into from
Oct 9, 2024

Conversation

saratavakoli77
Copy link
Contributor

Adding a Boolean field to the GuaranteedAnalysis class to check if the title has minimum, minimal, etc in it.

Issue #35

@k-allagbe k-allagbe linked an issue Oct 7, 2024 that may be closed by this pull request
As a dev, I want the pipeline to determine if the guaranteed analysis is minimal or not #35
Closed
k-allagbe
k-allagbe reviewed Oct 7, 2024
View reviewed changes
pipeline/inspection.py Outdated Show resolved Hide resolved
pipeline/inspection.py Outdated Show resolved Hide resolved
k-allagbe
k-allagbe reviewed Oct 8, 2024
View reviewed changes
pipeline/inspection.py Outdated Show resolved Hide resolved
k-allagbe
k-allagbe approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@k-allagbe k-allagbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main and update the tests.

@saratavakoli77
Copy link
Contributor Author

Please rebase on main and update the tests.

Done

@saratavakoli77 saratavakoli77 merged commit 547fa7a into main Oct 9, 2024
3 checks passed
@saratavakoli77 saratavakoli77 deleted the 35-minimal-guaranteed-analysis branch October 9, 2024 18:42
@saratavakoli77 saratavakoli77 restored the 35-minimal-guaranteed-analysis branch October 9, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-allagbe k-allagbe k-allagbe approved these changes

@Endlessflow Endlessflow Awaiting requested review from Endlessflow

@snakedye snakedye Awaiting requested review from snakedye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a dev, I want the pipeline to determine if the guaranteed analysis is minimal or not
2 participants
@saratavakoli77 @k-allagbe