Add redirection and logout button to the login functionality #249

SamuelPelletierEvraire · 2024-09-24T20:10:54Z

Add rederect to loginPage if not authentificated else go to homePage
Add authUtils that look if the user is authentificated.
Add rederection to HomePage when login sucessfully

This pull request resolve 3 issue #226 #224 and #222

Add rederect to loginPage if not authentificated else go to homePage Add authUtils that look if the user is authentificated. Add rederection to HomePage when login sucessfully

k-allagbe

Great start.
Few things to consider:

Should access to the main page (home) be prevented when the user is not logged in?
In your implementation, can the user log in with another account after the first login?
I suggest the login remain in the settings page.

Add authUtils that look if the user is authentificated. Add rederection to HomePage when login sucessfully Add logout button if the user is already connected

src/Pages/SettingPage/SettingPage.tsx

src/Utils/Auth/AuthUtil.ts

src/Pages/SettingPage/SettingPage.tsx

src/App.tsx

src/Pages/SettingPage/SettingPage.tsx

@k-allagbe

and fix last comment by @k-allagbe

@k-allagbe

and fix last comment by @k-allagbe

…ain-page-after-logging-in

Add new Login page separate from setting page

101749a

Add rederect to loginPage if not authentificated else go to homePage Add authUtils that look if the user is authentificated. Add rederection to HomePage when login sucessfully

SamuelPelletierEvraire self-assigned this Sep 24, 2024

SamuelPelletierEvraire requested a review from a team as a code owner September 24, 2024 20:10

SamuelPelletierEvraire linked an issue Sep 24, 2024 that may be closed by this pull request

As a user, I want the first page to be the login page. #224

Closed

1 task

SamuelPelletierEvraire had a problem deploying to experimental September 24, 2024 20:11 — with GitHub Actions Failure

fix lint

2727e60

SamuelPelletierEvraire temporarily deployed to experimental September 24, 2024 20:13 — with GitHub Actions Inactive

SamuelPelletierEvraire requested review from Youllou and k-allagbe September 24, 2024 20:14

fix all file should finish with a newline

803ea06

SamuelPelletierEvraire temporarily deployed to experimental September 24, 2024 20:15 — with GitHub Actions Inactive

fix all file should finish with a newline

c1b7d68

SamuelPelletierEvraire temporarily deployed to experimental September 24, 2024 20:17 — with GitHub Actions Inactive

fix refresh page

39f9a56

SamuelPelletierEvraire temporarily deployed to experimental September 24, 2024 21:35 — with GitHub Actions Inactive

k-allagbe reviewed Sep 25, 2024

View reviewed changes

k-allagbe linked an issue Sep 25, 2024 that may be closed by this pull request

As a user, I want to be directed to the main page after logging in #226

Closed

3 tasks

This was unlinked from issues Sep 25, 2024

As a user, I want the first page to be the login page. #224

Closed

As a user, I want to be directed to the main page after logging in #226

Closed

This was linked to issues Sep 25, 2024

As a user, I want the first page to be the login page. #224

Closed

As a user, I want to be directed to the main page after logging in #226

Closed

Add rederect to settingPage if not authentificated else go to homePage

9c2097d

Add authUtils that look if the user is authentificated. Add rederection to HomePage when login sucessfully Add logout button if the user is already connected

SamuelPelletierEvraire had a problem deploying to experimental September 25, 2024 14:33 — with GitHub Actions Failure

fix lint

9822a59

SamuelPelletierEvraire temporarily deployed to experimental September 25, 2024 14:34 — with GitHub Actions Inactive

fix missing import error during merge conflit

395af02

SamuelPelletierEvraire temporarily deployed to experimental September 25, 2024 14:35 — with GitHub Actions Inactive

SamuelPelletierEvraire changed the title ~~Add new Login page separate from setting page~~ Add redirection and logout button to the login functionality Sep 25, 2024

removing LoginPage

aa38f0e

SamuelPelletierEvraire temporarily deployed to experimental September 25, 2024 15:34 — with GitHub Actions Inactive

SamuelPelletierEvraire had a problem deploying to experimental September 25, 2024 19:09 — with GitHub Actions Failure

SamuelPelletierEvraire linked an issue Sep 25, 2024 that may be closed by this pull request

As a dev, I want to lock the login and signup button until there's a response. #222

Closed

fix lint

a1c8c32

SamuelPelletierEvraire temporarily deployed to experimental September 25, 2024 19:11 — with GitHub Actions Inactive

fix the refresh that was remove after quick ask to gpt

daf1c0d

SamuelPelletierEvraire had a problem deploying to experimental September 25, 2024 19:43 — with GitHub Actions Failure

fix lint

43e519e

SamuelPelletierEvraire temporarily deployed to experimental September 25, 2024 19:45 — with GitHub Actions Inactive

k-allagbe reviewed Sep 26, 2024

View reviewed changes

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

src/Utils/Auth/AuthUtil.ts Show resolved Hide resolved

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

k-allagbe reviewed Sep 26, 2024

View reviewed changes

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

k-allagbe reviewed Sep 26, 2024

View reviewed changes

src/App.tsx Show resolved Hide resolved

src/Pages/SettingPage/SettingPage.tsx Outdated Show resolved Hide resolved

Fix the comment made buy @k-allagbe

2586339

SamuelPelletierEvraire had a problem deploying to experimental October 1, 2024 17:06 — with GitHub Actions Failure

fix lint

488de28

and fix last comment by @k-allagbe

SamuelPelletierEvraire had a problem deploying to experimental October 1, 2024 17:18 — with GitHub Actions Failure

fix lint

877aada

and fix last comment by @k-allagbe

SamuelPelletierEvraire temporarily deployed to experimental October 1, 2024 17:25 — with GitHub Actions Inactive

Fix the redirectoring that was not working all the time

9ef69b4

SamuelPelletierEvraire had a problem deploying to experimental October 3, 2024 17:22 — with GitHub Actions Failure

fix lint

e7a779f

SamuelPelletierEvraire temporarily deployed to experimental October 3, 2024 17:31 — with GitHub Actions Inactive

last fix to make the redirection work

5b72c43

SamuelPelletierEvraire temporarily deployed to experimental October 3, 2024 18:34 — with GitHub Actions Inactive

k-allagbe added 2 commits October 4, 2024 17:53

issue #226: use axios to handle timeouts

4f219d8

Merge branch 'main' into 226-as-a-user-i-want-to-be-directed-to-the-m…

a1359ef

…ain-page-after-logging-in

k-allagbe temporarily deployed to experimental October 4, 2024 21:57 — with GitHub Actions Inactive

k-allagbe approved these changes Oct 4, 2024

View reviewed changes

k-allagbe self-assigned this Oct 4, 2024

k-allagbe merged commit 46e7253 into main Oct 4, 2024
8 checks passed

k-allagbe temporarily deployed to experimental October 4, 2024 22:02 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add redirection and logout button to the login functionality #249

Add redirection and logout button to the login functionality #249

SamuelPelletierEvraire commented Sep 24, 2024 •

edited

Loading

k-allagbe left a comment

Add redirection and logout button to the login functionality #249

Add redirection and logout button to the login functionality #249

Conversation

SamuelPelletierEvraire commented Sep 24, 2024 • edited Loading

k-allagbe left a comment

Choose a reason for hiding this comment

SamuelPelletierEvraire commented Sep 24, 2024 •

edited

Loading