Clippy #1
Merged
Clippy #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedtadde
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM!
Big thanks for the improvements @chris-ha458 . Event though I am still in the process of learning the language, I can definitely see that the changes yield better quality code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I saw your reddit post and gave it a slight go.
Most of my observation and suggestions come from
cargo clippy,cargo clippy -- -Wclippy::pedanticand my minds clippy (especially potential functional conversions)Some of these are about idiomatic rust code and some are about opinionated style choices (especially
clippy::pedantic)I tried to categorize them into relevant parts.
Feel free to cherrypick as you see fit