Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of care taking on the code itself. #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

A bit of care taking on the code itself. #13

wants to merge 6 commits into from

Conversation

petsagouris
Copy link

@petsagouris petsagouris commented Aug 18, 2016

No functionality has been altered.
The tests pass.
PHPDoc comments are working better and are more descriptive.
The code's logic is more shallow and thus more clarity.
Fixed a bug as well, see commit messages.

Signed-off-by: George Petsagourakis <[email protected]>
Mostly restructuring the logic statements for clarity and making code logic more shallow.
The bug fix is about the Collection.php file around @@180 that had `$this->getCollectionNames()` instead of `$this->database->getCollectionNames()`

Signed-off-by: George Petsagourakis <[email protected]>
…intersect_key` function.

Signed-off-by: George Petsagourakis <[email protected]>
Introducing throwing `RuntimeException` for `json_decode` errors.

Signed-off-by: George Petsagourakis <[email protected]>
…ng composer.lock.

The composer .lock is recommended that it is not committed as per Composer guidelines. (see https://getcomposer.org/doc/02-libraries.md#lock-file).

Also trying to make the conflict in Collection.php go away.
@petsagouris
Copy link
Author

I am trying to find where the conflict is so that I can fix it. Stay with me.

It is in line 205 which is correct. I don't see what it conflicts with.

@izharaazmi
Copy link

No response to the PR in THREE years and no core commits in TWO years. Looks like project is no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants