Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slice index for benchmark-8 2D #138

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix slice index for benchmark-8 2D #138

merged 1 commit into from
Aug 9, 2023

Conversation

charlesbmi
Copy link
Contributor

@charlesbmi charlesbmi commented Aug 8, 2023

Introduction

Scenario 2 is based on benchmark 8 of Aubry et al. (2022). NDK provides a 2D variant that is supposed to correspond to the slice through the transducer.

Changes

Fixes the slice index for benchmark 8's 2D variant to match the paper description:

Using 1-based indexing, the center of the source (rear of the bowl or center of the piston) relative to the output grid was positioned at... [1, 171, 191] for benchmark 8.

This also happens to be the middle slice: .shape[2] // 2. The 3-D mask.shape is (451, 341, 381)

TODO:

@NewtonSander
Copy link
Collaborator

@charlesincharge I took the liberty of rebasing your PR as I've fixed the issue that caused the CI to fail in the base branch

Base automatically changed from implementing_procedural_api to main August 9, 2023 16:20
@charlesbmi
Copy link
Contributor Author

Thanks!

@charlesbmi charlesbmi merged commit 0a31dab into main Aug 9, 2023
10 checks passed
@d-lucena d-lucena deleted the benchmark-8-slice branch August 9, 2023 23:08
NewtonSander pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants