Fix slice index for benchmark-8 2D #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Scenario 2 is based on benchmark 8 of Aubry et al. (2022). NDK provides a 2D variant that is supposed to correspond to the slice through the transducer.
Changes
Fixes the slice index for benchmark 8's 2D variant to match the paper description:
This also happens to be the middle slice:
.shape[2] // 2
. The 3-Dmask.shape
is(451, 341, 381)
TODO:
main
once Implementing new API for NDK #122 lands.