Allow to self-host the sample-assets directory (fix #702) (#766)

aframevr · Sep 8, 2024 · a8294dc · a8294dc
1 parent 408be16
commit a8294dc
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -49,3 +49,22 @@ npm start
 ```
 
 Then navigate to __[http://localhost:3333/examples/](http://localhost:3333/examples/)__
+
+## Self-hosting the sample-assets directory
+
+The textures modal is using https://aframe.io/sample-assets/dist/images.json
+to get the available textures.
+The GitHub repository for those assets is https://github.com/aframevr/sample-assets
+
+If you want to self-host this directory, do the following:
+
+```bash
+cd examples
+git clone [email protected]:aframevr/sample-assets.git
+```
+
+edit `index.html` and define before any script tag this global variable:
+
+```html
+<script>window.AFRAME_SAMPLE_ASSETS_ROOT = "./sample-assets/";</script>
+```
diff --git a/examples/index.html b/examples/index.html
@@ -3,6 +3,7 @@
   <head>
     <meta charset="utf-8">
     <title>Example Scene</title>
+    <!--<script>window.AFRAME_SAMPLE_ASSETS_ROOT = "./sample-assets/";</script>-->
     <script src="https://cdn.jsdelivr.net/gh/aframevr/aframe@master/dist/aframe-master.min.js"></script>
     <script src="https://unpkg.com/[email protected]/dist/aframe-environment-component.min.js"></script>
   </head>

diff --git a/src/lib/assetsLoader.js b/src/lib/assetsLoader.js
@@ -1,6 +1,7 @@
 import Events from './Events';
 
-const assetsBaseUrl = 'https://aframe.io/sample-assets/';
+const assetsBaseUrl =
+  window.AFRAME_SAMPLE_ASSETS_ROOT || 'https://aframe.io/sample-assets/';
 const assetsRelativeUrl = { images: 'dist/images.json' };
 
 /**