Resolve memory leak caused by circular reference in client finalizer #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reugn Thanks for the pull request. Is the issue the finalizer not being called, or the memory leak after the finalizer call? |
|
The finalizer is not being called, causing the memory leak. |
khaf
added a commit
that referenced
this pull request
Jul 22, 2024
* Update CHANGELOG * [CLIENT-3022] Close() throws a nil point error on ProxyClient without Authentication * [CLIENT-3044] Resolve memory leak caused by circular reference in client finalizer (#441) * [CLIENT-3045] Move proxy client build behind a build flag This removes the GRPC compilation and potential namespace conflict from the default build and moves it behind the compiler build flag "as_proxy" * Update dependencies * [CLIENT-3047] Fix pointer value assignment in baseMultiCommand.parseKey (#443) * [CLIENT-3048] Use precomputed ops variable in batchIndexCommandGet.executeSingle (#442) * [CLIENT-3046] Wrong return type in Single Key Batch Operations with Multiple Ops per Bin * [CLIENT-3022] Optimize the ticker * [CLIENT-3022] Close the ticker * [CLIENT-3049] Use a specialized pool for grpc conns to prevent premature reaping Also fixes namespace parameter for a few code examples. * Skip a few unsupported tests in the DBAAS environment --------- Co-authored-by: Eugene R. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A circular reference between the client object and the cluster object prevents the client's finalizer from executing, resulting in a memory leak. The issue can be reproduced by creating and closing multiple client instances in a loop.
To resolve this, the client instance has been injected into the batch commands directly.