disable some lua functions #306
Conversation
|
sync success |
|
Nov 1 05:18:42.040 INF ../go/aergo/cmd/aergosvr/aergosvr.go:100 > AERGO SVR STARTED branch=topic/disable-lua-require module=asvr revision=b9d3bb50 |
|
@kslee8282 |
| getmetatable(bignum.number(0)).__add = function(x,y) return x-y end | ||
| if getmetatable ~= nil then | ||
| -- override the __add metamethod on bignum module | ||
| getmetatable(bignum.number(0)).__add = function(x,y) return x-y end |
There was a problem hiding this comment.
I don't review deeper code about getmemtable, but it doesn't look like addtion rather substraction. Anyway, if this code did not cause any problem, we can leave this as is, since this commit don't change the code.
There was a problem hiding this comment.
yes, this test overrides the add (+) operator with a subtraction (-) to check if that feature of overriding functions is possible. the feature is disabled by this PR
This PR removes some Lua functions, starting on hardfork 4:
packagemodulerequiregetfenvsetfenvgetmetatablesetmetatablerawgetrawsetrawequalstring.dumpThey continue existing for previous hardforks for compatibility with gas computations. The first 4 are also available when Aergo is build in debug mode
This PR also does not build some disabled packages (os, io, jit, debug) and so the code cannot be accessed in any way
It includes tests to make sure the disabled modules and functions are not available