bignum.ispositive() + bignum.isnegative() #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: the tests must be run for all the hardfork versions |
|
PROBLEM: it is giving difference in gas on V4 when new functions are added to the module If we comment the lines that add the new functions, it gives the expected value. When we uncomment the lines (and the functions are added) it gives another amount of gas The result can be seen here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new functions:
bignum.ispositive()bignum.isnegative()The last one is a clone of the
bignum.isneg(). Both will exist (for backwards compatibility) but the docs and code completion on the web editor will mention onlybignum.isnegative()