deploy contracts as plain code #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hayarobi This is one of the most important PRs |
|
Does this path prevent deploying compiled code?Is it breaking backward compatibility? |
Merged
|
I think @hayarobi made a valid question regarding already deployed compiled code. It should be implemented to prevent new code deploys in bytecode format but allow existing code to run to ensure backward compatibility. |
shepelt
reviewed
May 8, 2024
| codePayload := luacUtil.LuaCodePayload(payload) | ||
| if _, err := codePayload.IsValidFormat(); err != nil { | ||
| ctrLgr.Warn().Err(err).Str("contract", types.EncodeAddress(contractAddress)).Msg("deploy") | ||
| return nil, nil, err | ||
| } | ||
| code := codePayload.Code() | ||
|
|
||
| // if hardfork version 4 | ||
| if ctx.blockInfo.ForkVersion >= 4 { |
There was a problem hiding this comment.
I think this part would insure that code running in blocks with forkversion < 4 to run as previously @hayarobi
There was a problem hiding this comment.
The contract execution code was not modified. It remains exactly the same
|
@hayarobi please finish review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.