Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if the app can not init Firebase #356

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

armanddidierjean
Copy link
Member

@armanddidierjean armanddidierjean commented Apr 27, 2024

but log a warning in logs

Solve #192

How to test

You may need to run flutter clean to remove existing Firebase files
On iOS and Android, try to launch without the file:

  • ios/config/<flavor>/GoogleService-Info.plist or
  • android/app/src/<flavor>/google-services.json
    The app should work, but a warning should be logged

to be able to chain logger methods
@armanddidierjean armanddidierjean added the enhancement New feature or request label Apr 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.71%. Comparing base (cddfd38) to head (97fe30f).

Files Patch % Lines
lib/tools/logs/logger.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files         168      168           
  Lines        3670     3670           
=======================================
  Hits         2008     2008           
  Misses       1662     1662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

and log on error
@julien4215
Copy link
Collaborator

This does not work on Android.

I get the following error when trying to launch Titan on Android without the google-services.json :

* What went wrong:
Execution failed for task ':app:processDevDebugGoogleServices'.
> File google-services.json is missing. The Google Services Plugin cannot function without it. 

@armanddidierjean armanddidierjean added the notification This PR works on notification label Apr 30, 2024
@julien4215 julien4215 marked this pull request as draft June 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request notification This PR works on notification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants