Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nuxt 3.12.4 and Vue 3.2.47 #229

Merged
merged 15 commits into from
Aug 27, 2024
Merged

Upgrade to Nuxt 3.12.4 and Vue 3.2.47 #229

merged 15 commits into from
Aug 27, 2024

Conversation

gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Aug 23, 2024

Upgrade of the underlying frameworks to address a major vulnerability.

This PR has involved a major refactoring as Nuxt3 is completely different:

  • implemented in Typescript
  • refactor all Vue pages
  • implemented server-side APIs as API Routes
  • removed unnecessary dependencies (Express, dotenv, crossenv)
  • moved assets to public folder

Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatanese Nice work!

  • gitpod.yml is still using port 8080, let's make sure it's changed to port 3000
  • Double check if the npm run dev still applies when spinning-up this repo in gitpod

pages/index.vue Outdated Show resolved Hide resolved
pages/checkout/[type].vue Outdated Show resolved Hide resolved
pages/checkout/[type].vue Outdated Show resolved Hide resolved
plugins/adyen-web.client.ts Outdated Show resolved Hide resolved
plugins/adyen-web.js Show resolved Hide resolved
server/api/sessions.post.ts Outdated Show resolved Hide resolved
server/api/sessions.post.ts Outdated Show resolved Hide resolved
server/api/webhooks/notifications.post.js Outdated Show resolved Hide resolved
server/api/webhooks/notifications.post.js Outdated Show resolved Hide resolved
server/api/webhooks/notifications.post.js Outdated Show resolved Hide resolved
@gcatanese
Copy link
Contributor Author

Thanks @Kwok-he-Chu, I have addressed your comments, please have final look. Tnx

Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing: When gitpod spins-up, the user is prompted with Nuxt collects completely anonymous data about usage. Users have to answer with yes/no in the terminal, can we somehow add this flag so that it defaults to no?

See screenshot:
image

@gcatanese
Copy link
Contributor Author

Minor thing: When gitpod spins-up, the user is prompted with Nuxt collects completely anonymous data about usage. Users have to answer with yes/no in the terminal, can we somehow add this flag so that it defaults to no?

Yes, well spotted, I have disabled the telemetry

@gcatanese gcatanese merged commit 01c1e15 into main Aug 27, 2024
3 checks passed
@gcatanese gcatanese deleted the nuxt3 branch August 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants