Skip to content

Vite's `server.fs.deny` did not deny requests for patterns with directories.

Moderate severity GitHub Reviewed Published Apr 3, 2024 in vitejs/vite • Updated Apr 4, 2024

Package

npm vite (npm)

Affected versions

>= 2.7.0, <= 2.9.17
>= 3.0.0, <= 3.2.8
>= 4.0.0, <= 4.5.2
>= 5.0.0, <= 5.0.12
>= 5.1.0, <= 5.1.6
>= 5.2.0, <= 5.2.5

Patched versions

2.9.18
3.2.10
4.5.3
5.0.13
5.1.7
5.2.6

Description

Summary

Vite dev server option server.fs.deny did not deny requests for patterns with directories. An example of such a pattern is /foo/**/*.

Impact

Only apps setting a custom server.fs.deny that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected.

Patches

Fixed in [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

Details

server.fs.deny uses picomatch with the config of { matchBase: true }. matchBase only matches the basename of the file, not the path due to a bug (micromatch/picomatch#89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set { dot: true } and that causes dotfiles not to be denied unless they are explicitly defined.

Reproduction

Set fs.deny to ['**/.git/**'] and then curl for /.git/config.

  • with matchBase: true, you can get any file under .git/ (config, HEAD, etc).
  • with matchBase: false, you cannot get any file under .git/ (config, HEAD, etc).

References

@sapphi-red sapphi-red published to vitejs/vite Apr 3, 2024
Published to the GitHub Advisory Database Apr 3, 2024
Reviewed Apr 3, 2024
Published by the National Vulnerability Database Apr 4, 2024
Last updated Apr 4, 2024

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
None
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N

EPSS score

0.044%
(11th percentile)

Weaknesses

CVE ID

CVE-2024-31207

GHSA ID

GHSA-8jhw-289h-jh2g

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.