Skip to content

avo possible unsafe reflection / partial DoS vulnerability

High severity GitHub Reviewed Published Jun 5, 2023 in avo-hq/avo • Updated Jun 25, 2024

Package

bundler avo (RubyGems)

Affected versions

<= 2.33.2
>= 3.0.0.pre1, <= 3.0.0.pre12

Patched versions

2.33.3

Description

Summary

The polymorphic field type stores the classes to operate on when updating a record with user input, and does not validate them in the back end. This can lead to unexpected behavior, remote code execution, or application crashes when viewing a manipulated record.

Details

After reviewing the polymorphic field implementation and performing some black box approaches, we identified a potential security issue related to the use of safe_constantize / constantize. This Rails functionality is capable of searching for classes within the Rails context and returning the class for further use. Because Avo does not validate user input when updating or creating a new polymorphic resource, it is possible to create database entries with completely different or invalid class names than the preselected ones. Avo assumes that the class specified by the user request is a valid one and attempts to work with it, which may result in dangerous behavior and code execution.

PoC

image
In the test scenario we choose the demo app and the review resource which has a polymorphic reviewable field.

image
Intercepting the request and switching the review[reviewable_type] from “Fish” to “File” which is a real class inside Rails

image
Corrupting the database with unusable classes will cause a crash at the application while viewing the new record or the index view (partial DoS)

image
Manual delete the corrupted resource in order to recover the applications functionality

image
Of course it is possible to use other class names or namespaces. The local development environment displays the backend error message when visiting a corrupted record. Avo is trying to apply a scope to this class that does not exist.

image
Specifying an invalid class name in the parameter will cause the application to crash again while trying constanize the provided string

Impact

The final exploitation of this vulnerability requires more time than is provided in this assessment, but initial testing of the post request shows the potential critical risk. The classes could be instantiated at any point in the code and this could also lead to code execution.

Recommendation

Avo should be configured to never trust user-supplied input, especially when defining classes for records. In this particular case, Avo can evaluate the options list given for the polymorphic field and only allow strings from that list. With this white-list approach, an attacker cannot supply unintended classes.

References

@adrianthedev adrianthedev published to avo-hq/avo Jun 5, 2023
Published by the National Vulnerability Database Jun 5, 2023
Published to the GitHub Advisory Database Jun 6, 2023
Reviewed Jun 6, 2023
Last updated Jun 25, 2024

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
Low
User interaction
None
Scope
Unchanged
Confidentiality
Low
Integrity
High
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:L/I:H/A:H

EPSS score

0.240%
(62nd percentile)

CVE ID

CVE-2023-34102

GHSA ID

GHSA-86h2-2g4g-29qx

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.