Skip to content

Commit

Permalink
version 1.3.4 skip tests on cran
Browse files Browse the repository at this point in the history
add condition on publish example
  • Loading branch information
adrtod committed Mar 8, 2021
1 parent aa41522 commit 691a100
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rchallenge
Title: A Simple Data Science Challenge System
Version: 1.3.3
Version: 1.3.4
Authors@R: c(person("Adrien", "Todeschini", email = "[email protected]", role=c("aut", "cre")),
person("Robin", "Genuer", email = "[email protected]", role=c("ctb")))
Description: A simple data science challenge system using R Markdown and 'Dropbox' <https://www.dropbox.com/>.
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# rchallenge 1.3.4 (08-03-2021)
- Skip test for pandoc availability on CRAN.
- Added condition on publish() example.

# rchallenge 1.3.3 (05-03-2021)
- Use South German Credit data from [UCI ML Repository](https://archive.ics.uci.edu/ml/datasets/South+German+Credit)

Expand Down
4 changes: 3 additions & 1 deletion R/new.r
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,9 @@ new_team <- function(..., path = ".", submissions_dir = "submissions",
#' wd <- setwd(path)
#' new_challenge()
#' outdir = tempdir()
#' publish(output_dir = outdir, output_options = list(self_contained = FALSE))
#' if (rmarkdown::pandoc_available('1.12.3')) {
#' publish(output_dir = outdir, output_options = list(self_contained = FALSE))
#' }
#' unlink(outdir)
#' setwd(wd)
#' unlink(path)
Expand Down
8 changes: 0 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,3 @@ We checked 0 reverse dependencies, comparing R CMD check results across CRAN and
* We saw 0 new problems
* We failed to check 0 packages

## Resubmission

This is a resubmission. In this version I have:

* changed http --> https, added trailing slashes, or followed moved content as
appropriate.

* linked to files in the package or used fully specified URLs.
4 changes: 3 additions & 1 deletion man/publish.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/testthat/test-pandoc.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
test_that("pandoc available", {
skip_on_cran()
expect_true(rmarkdown::pandoc_available('1.12.3'))
})

0 comments on commit 691a100

Please sign in to comment.