-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prettier config and test npm script #232
Merged
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9e8995e
feat: add prettier config and test npm script
karstens 61653ec
fix: remove obsolete npm scripts for prettier
karstens 4abc85a
fix: run prettier on packages/contrast-color/**
karstens fc18950
fix: remove package-lock.json
karstens 7b60e29
fix: prettier on docs/ui/moon.yml
karstens fd7bc41
fix: run prettier on packages/**/*.*
karstens 4b053a9
fix: little improvements
karstens ad19474
fix: add husky pre-commit for git hook
karstens d04b307
fix: add husky/_ ti .gitignore
karstens cb6b9a2
refactor: move lint-staged to pnpm script
GarthDB cdb0dbe
fix: added husky commitlint workflow
GarthDB 2233d88
chore: updated branch from monorepo
GarthDB b029a03
fix: added .gitignore to .husky
GarthDB ea2f3ad
Merge branch 'monorepo' into karstens/fix--little-improvements
GarthDB 8c91134
fix: replace npx with pnpm in node scripts
karstens e17c4a2
fix: .husky/commit-msg hook was ignored because it is not set as exec…
karstens 30ab9ac
ci: added simple github workflow to running tests
GarthDB a2b9d9f
refactor: moved scripts to moon tasks to make it easy to test in CI
GarthDB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: CI | ||
on: pull_request | ||
jobs: | ||
ci: | ||
name: CI | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
- uses: moonrepo/setup-moon-action@v1 | ||
- run: moon ci | ||
- uses: 'moonrepo/run-report-action@v1' | ||
if: success() || failure() | ||
with: | ||
access-token: ${{ secrets.MOON_GH_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
dist/ | ||
node_modules/ | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
.nyc_output/ | ||
.cache/ | ||
.DS_Store | ||
# moon | ||
.moon/cache | ||
.moon/docker | ||
.parcel-cache | ||
|
||
# husky | ||
.husky/_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[submodule "packages/contrast-colors/SAPC-APCA"] | ||
path = packages/contrast-colors/SAPC-APCA | ||
url = [email protected]:Myndex/SAPC-APCA.git | ||
[submodule "packages/ui/src/c3"] | ||
path = packages/ui/src/c3 | ||
[submodule "docs/ui/src/c3"] | ||
path = docs/ui/src/c3 | ||
url = [email protected]:StanfordHCI/c3.git |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules/ | ||
*.min.js | ||
*.map | ||
*.snap |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"tabWidth": 2, | ||
"printWidth": 256, | ||
"singleQuote": true, | ||
"bracketSpacing": false, | ||
"trailingComma": "none" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
$schema: "https://moonrepo.dev/schemas/project.json" | ||
$schema: 'https://moonrepo.dev/schemas/project.json' | ||
dependsOn: | ||
- contrast-colors |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,16 +6,16 @@ | |
"repository": "[email protected]:adobe/leonardo.git", | ||
"author": "Nate Baldwin <[email protected]>", | ||
"scripts": { | ||
"serve": "npx parcel src/index.html src/theme.html src/scales.html src/tools.html src/demo.html --no-hmr", | ||
"serve": "pnpm parcel src/index.html src/theme.html src/scales.html src/tools.html src/demo.html --no-hmr", | ||
"clean": "rm -rf dist/*", | ||
"dev": "pnpm copyIcons && pnpm serve", | ||
"copyIcons": "mkdir -p dist && pnpm copyWorkflowIcons && pnpm copyUIIcons", | ||
"copyWorkflowIcons": "cp -r node_modules/@adobe/spectrum-css-workflow-icons/dist/spectrum-icons.svg dist/", | ||
"copyUIIcons": "cp -r node_modules/@spectrum-css/icon/dist/spectrum-css-icons.svg dist/", | ||
"copyCNAME": "cp -r src/CNAME dist/CNAME", | ||
"postPublish": "pnpm deploySite", | ||
"buildSite": "npx parcel build --no-optimize src/index.html src/scales.html src/tools.html src/theme.html src/demo.html --public-url ./ && pnpm copyCNAME && pnpm copyIcons", | ||
"deploySite": "pnpm clean && pnpm buildSite && npx gh-pages -d dist" | ||
"buildSite": "pnpm parcel build --no-optimize src/index.html src/scales.html src/tools.html src/theme.html src/demo.html --public-url ./ && pnpm copyCNAME && pnpm copyIcons", | ||
"deploySite": "pnpm clean && pnpm buildSite && pnpm gh-pages -d dist" | ||
}, | ||
"keywords": [ | ||
"accessibility", | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GarthDB should this really run
moon ci
? Currently,moon ci
run all tasks, including thedeploySite
task. Is that what should happen here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it would be enough to run the test and build tasks here, like:
moon ci :lint :test :buildSite
https://moonrepo.dev/docs/guides/ci#choosing-targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I move the tasks to moon I can define which ones are local only.