Rebuild UMAPI Cache Tables After Version Change #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add version check in UmapiCache init. add rebuild_tables method to call if version has been updated
|
@ddybvig-perf please resolve the merge conflicts and I'll take a look. |
adorton-adobe
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a new method to the UMAPICache class, rebuild_tables, that will drop existing tables in the UMAPI cache and then rebuild them. This method gets called when the version number is incremented.
Testing Steps
I added one test to test_cache.py to check that the method successfully drops the tables and then rebuilds them.
Fixes #212