fix(script): remove flaky window load event listener

adil192 · Dec 11, 2023 · 37c0b71 · 37c0b71
1 parent 3c2ed70
commit 37c0b71
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 Here I will outline the changes I've made over time...
 
+### 20231211
+
+- Fixed the add_course_images script sometimes not working
+
 ### 20231204
 
 - Added popup icons when you play/pause a video (just like on YouTube)

diff --git a/scripts/add_course_images.js b/scripts/add_course_images.js
@@ -1,7 +1,7 @@
 // ==UserScript==
 // @name         UoM Blackboard: Add course images
 // @namespace    http://tampermonkey.net/
-// @version      20231129.00.00
+// @version      20231211.00.00
 // @description  An optional accompanying script for https://github.com/adil192/BlackboardTheme, which adds course images to the Blackboard homepage.
 // @author       adil192
 // @match        https://online.manchester.ac.uk/webapps/portal/*
@@ -69,15 +69,13 @@ function labelCourses() {
     'use strict';
 
     console.log("UoM Blackboard: Add course images");
-    window.addEventListener("load", () => {
-        findCoursesDivs().then(() => {
-            labelCourses();
+    findCoursesDivs().then(() => {
+        labelCourses();
 
-            coursesDivs.forEach((coursesDiv) => {
-                coursesDiv.addEventListener("DOMSubtreeModified", () => {
-                    labelCourses();
-                }, { passive: true });
-            });
+        coursesDivs.forEach((coursesDiv) => {
+            coursesDiv.addEventListener("DOMSubtreeModified", () => {
+                labelCourses();
+            }, { passive: true });
         });
-    }, { once: true, passive: true });
+    });
 })();