Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parse error handling #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve parse error handling #126

wants to merge 4 commits into from

Conversation

akx
Copy link
Collaborator

@akx akx commented Apr 11, 2024

  • Log the Pyparsing explain() context for a parse failure
  • Don't fail entire parsing if a wildcard value is not parseable

Refs adieyal/sd-dynamic-prompts#572

@akx akx requested a review from adieyal April 11, 2024 10:50
@akx akx added bug Something isn't working enhancement New feature or request labels Apr 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (1d2a8e9) to head (7031ebc).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   97.29%   97.31%   +0.01%     
==========================================
  Files          77       77              
  Lines        3364     3388      +24     
==========================================
+ Hits         3273     3297      +24     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants