Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependency pins #122

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Loosen dependency pins #122

merged 2 commits into from
Mar 21, 2024

Conversation

akx
Copy link
Collaborator

@akx akx commented Mar 21, 2024

Refs adieyal/sd-dynamic-prompts#743.

We don't want the transitive torch dependency from an older version of transformers to try and install an older Torch.

I tested that magicprompts works fine with transformers==4.39.0 – hopefully HF won't break things before version 5 of Transformers.

@akx akx requested a review from adieyal March 21, 2024 06:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.26%. Comparing base (e377980) to head (aae0bc3).
Report is 1 commits behind head on main.

Files Patch % Lines
tests/generators/test_magicprompt.py 40.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   97.43%   97.26%   -0.18%     
==========================================
  Files          77       77              
  Lines        3358     3368      +10     
==========================================
+ Hits         3272     3276       +4     
- Misses         86       92       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx merged commit 1d2a8e9 into adieyal:main Mar 21, 2024
5 of 7 checks passed
@akx akx deleted the loosen-deps branch March 21, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants