Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster CI #109

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Faster CI #109

merged 4 commits into from
Nov 17, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented Nov 13, 2023

This PR speeds up CI for the project at the expense of not downloading the transformers dependency.

We never used the dependency anyway, since the tests always mock the generator...

@akx akx marked this pull request as ready for review November 15, 2023 06:38
@akx akx requested a review from adieyal November 15, 2023 06:38
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b66bea8) 97.37% compared to head (c9df45e) 97.43%.

Files Patch % Lines
src/dynamicprompts/generators/magicprompt.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   97.37%   97.43%   +0.06%     
==========================================
  Files          75       75              
  Lines        3162     3160       -2     
==========================================
  Hits         3079     3079              
+ Misses         83       81       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adieyal adieyal merged commit 1c3ae20 into adieyal:main Nov 17, 2023
6 of 7 checks passed
@akx akx deleted the faster-ci branch November 18, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants