-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrap command #102
Add wrap command #102
Conversation
WDYT @adieyal? |
9972cc3
to
812d786
Compare
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know! |
812d786
to
20a4f20
Compare
I like the general idea of infill, although it feels a little complicated to use. Is the Do you have any concrete use cases that you've used it for? |
I agree it's a bit unwieldy. Without some sort of syntax like this, how would the wrapper know what to wrap? The examples from the tests are
I've ported the Fooocus style templates from https://github.com/lllyasviel/Fooocus/tree/main/sdxl_styles to wrapping wildcards, and have had fun with that; please enjoy this stably diffused melon: |
20a4f20
to
c10391a
Compare
c10391a
to
feafbdf
Compare
@adieyal WDYT, should we merge this? I don't think the |
Hey. I went through it this weekend. I think it's a great feature but I was
struggling to get it to work. Kept getting syntax errors with my prompts
(although the tests passed so I'm not sure why).
Let's merge it if you're happy that it's ready. I'll add to the docs once
I've figured out what I'm doing wrong.
…On Mon, 20 Nov 2023, 08:54 Aarni Koskela, ***@***.***> wrote:
@adieyal <https://github.com/adieyal> WDYT, should we merge this? I don't
think the %{a...c$$b} syntax should be breaking any current workflows,
even if it is a bit unwieldy (if someone comes up with a lighter-weight
syntax later, we could ship that too)?
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGXMRQWTW4A46LJU6WW2TYFL5CJAVCNFSM6AAAAAA7AF44CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJYGMZTONJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR adds a new wrap command.
The test says it all:
"%{__wrappers__$${fox|cow}}"
wrappers
withArt Deco, ..., sleek, geometric forms, art deco style
Pop Art, ...., vivid colors, flat color, 2D, strong lines, Pop Art
Art Deco, cow, sleek, geometric forms, art deco style
Art Deco, fox, sleek, geometric forms, art deco style
Pop Art, cow, vivid colors, flat color, 2D, strong lines, Pop Art
Pop Art, fox, vivid colors, flat color, 2D, strong lines, Pop Art
IOW, a marker string (3+ regular dots, or 1+ Unicode ellipsis character) within the
wrapper
component of the wrap command will be replaced with theinner
command's sampling result.This also works for things other than wildcards (despite the branch name):
...