Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Implementation #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Storybook Implementation #16

wants to merge 1 commit into from

Conversation

shawnmath
Copy link

  • Add storybook dependency. including addon for next.js; created rudimentary Header component & associated story

@llimllib
Copy link
Contributor

Thank you! I've not worked with storybook before, but I like the idea.

Here's what I see when I run this:

image

Is the idea that we can add more components to it as we go? Is the header supposed to look like something here?

@shawnmath
Copy link
Author

Yep, that's right - we'll add stories to components as we create them. I'd think we should make components from the USWDS system.

The refactored Header component is mostly as an example - it accepts children as props, so in the Header story I just added 3 links for display. We can include further variants to display, ie: left or right aligned header items, etc once we iron out what Header should do.

Currently, we can't display static assets in storybook but that is a config issue; I couldn't get to it in this PR. I just wanted to get the implementation up and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants