Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (common) initial common chart #44

Merged
merged 1 commit into from
Jun 30, 2020
Merged

✨ (common) initial common chart #44

merged 1 commit into from
Jun 30, 2020

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jun 30, 2020

Initial chart based on parts of incubator/common. The co authors on this
PR reflect the original authors on https://github.com/helm/charts.

Compared to the incubator version this has been stripped of some parts
that we currently do not have a use for.

  • add common chart
  • strip common chart of templates we don't currently use
  • reconfigure chart-testing GitHub Action to ignore library chart

I created an issue about testing library charts: helm/chart-testing#237
before I ignored the common chart.

There is a example of how this is used in #36

Initial chart based on parts of incubator/common. The co authors on this
PR reflect the original authors on https://github.com/helm/charts.

Compared to the incubator version this has been stripped of some parts
that we currently do not have a use for.

* [x] add common chart
* [x] strip common chart of templates we don't currently use
* [x] reconfigure chart-testing GitHub Action to ignore library chart

Co-authored-by: Matt Butcher <[email protected]>
Co-authored-by: Adnan Abdulhussein <[email protected]>
Co-authored-by: Guang Ya Liu <[email protected]>
Co-authored-by: David J. M. Karlsen <[email protected]>
Co-authored-by: Alexander Babai <[email protected]>
Co-authored-by: Javier Domingo Cansino <[email protected]>
@hairmare hairmare mentioned this pull request Jun 30, 2020
12 tasks
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

charts/common/templates/_fullname.tpl Show resolved Hide resolved
@hairmare hairmare merged commit 509b304 into adfinis:master Jun 30, 2020
@hairmare hairmare deleted the feat/common-chart branch June 30, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants