-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added possibility to prune xPaths #414
Conversation
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
- Coverage 96.82% 96.67% -0.15%
==========================================
Files 22 22
Lines 3334 3338 +4
==========================================
- Hits 3228 3227 -1
- Misses 106 111 +5
|
@HeLehm Thanks, the PR looks good, I'll hopefully merge it soon. |
Hi @adbar, any updates on this? Can I do something to help? |
Hi @HeLehm, I'll be afk for a little while but I'll merge your PR in October at the latest. In the meantime, could you please add the following tests? Not strictly speaking a coverage problem, rather a logical way to cover everything:
The two items can be combined. |
Thanks! I don't quite understand why the coverage changes should be an issue and I plan to merge the PR as it is. |
Same as I did in #259 .
Also: I added a simple test.