Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove values for _feedback._altTitle in sample course (fixes #3566) #3567

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 5, 2024

Fixes #3566

Fix

  • Removes values for _feedback._altTitle in sample course. Keeps the property in place.

Related

adaptlearning/adapt-contrib-core#551

@swashbuck swashbuck self-assigned this Jun 5, 2024
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit a0e03c0 into master Jun 7, 2024
3 checks passed
@joe-allen-89 joe-allen-89 deleted the issue/3566 branch June 7, 2024 08:48
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
## [5.39.9](v5.39.8...v5.39.9) (2024-06-07)

### Fix

* Remove values for _feedback._altTitle in sample course (fixes #3567) ([a0e03c0](a0e03c0)), closes [#3567](#3567)
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 5.39.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kirsty-hames added a commit that referenced this pull request Jun 10, 2024
* Fix: Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.8 [skip ci]

## [5.39.8](v5.39.7...v5.39.8) (2024-06-07)

### Fix

* Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564) ([514449a](514449a)), closes [#3564](#3564)

* Fix: Remove values for _feedback._altTitle in sample course (fixes #3567)

* Chore(release): 5.39.9 [skip ci]

## [5.39.9](v5.39.8...v5.39.9) (2024-06-07)

### Fix

* Remove values for _feedback._altTitle in sample course (fixes #3567) ([a0e03c0](a0e03c0)), closes [#3567](#3567)

* Fix: Default to secure connection for bower registry (fixes #3550)

* Chore(release): 5.39.10 [skip ci]

## [5.39.10](v5.39.9...v5.39.10) (2024-06-07)

### Fix

* Default to secure connection for bower registry (fixes #3550) ([8594304](8594304)), closes [#3550](#3550)

* Fix: Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.11 [skip ci]

## [5.39.11](v5.39.10...v5.39.11) (2024-06-07)

### Fix

* Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568) ([fda22a8](fda22a8)), closes [#3568](#3568)

---------

Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: oliverfoster <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Brad Simpson <[email protected]>
joe-allen-89 pushed a commit that referenced this pull request Jun 11, 2024
#3570)

* partly correct aria labels added to course _globals

* merge master into issue/3565 (#3569)

* Fix: Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.8 [skip ci]

## [5.39.8](v5.39.7...v5.39.8) (2024-06-07)

### Fix

* Bumping core to v6.49.0 automatically via 'frameworkpullrequest' Github action (#3564) ([514449a](514449a)), closes [#3564](#3564)

* Fix: Remove values for _feedback._altTitle in sample course (fixes #3567)

* Chore(release): 5.39.9 [skip ci]

## [5.39.9](v5.39.8...v5.39.9) (2024-06-07)

### Fix

* Remove values for _feedback._altTitle in sample course (fixes #3567) ([a0e03c0](a0e03c0)), closes [#3567](#3567)

* Fix: Default to secure connection for bower registry (fixes #3550)

* Chore(release): 5.39.10 [skip ci]

## [5.39.10](v5.39.9...v5.39.10) (2024-06-07)

### Fix

* Default to secure connection for bower registry (fixes #3550) ([8594304](8594304)), closes [#3550](#3550)

* Fix: Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568)

Co-authored-by: oliverfoster <[email protected]>

* Chore(release): 5.39.11 [skip ci]

## [5.39.11](v5.39.10...v5.39.11) (2024-06-07)

### Fix

* Bumping core to v6.50.0 automatically via 'frameworkpullrequest' Github action (#3568) ([fda22a8](fda22a8)), closes [#3568](#3568)

---------

Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: oliverfoster <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Brad Simpson <[email protected]>

* resolve package-lock.json conflicts

* resolve .gitmodules conflicts

* resolve package.json conflicts

* resolve package-lock.json conflicts

---------

Co-authored-by: Oliver Foster <[email protected]>
Co-authored-by: oliverfoster <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Brad Simpson <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jun 26, 2024
# [5.40.0](v5.39.15...v5.40.0) (2024-06-26)

### Fix

* Bumping core to v6.52.0 automatically via 'frameworkpullrequest' Github action (#3579) ([a226704](a226704)), closes [#3579](#3579)

### New

* partly correct aria labels added to course _globals (fixes #3565) (#3570) ([fcd6bab](fcd6bab)), closes [#3565](#3565) [#3570](#3570) [#3569](#3569) [#3564](#3564) [#3564](#3564) [#3567](#3567) [#3567](#3567) [#3567](#3567) [#3550](#3550) [#3550](#3550) [#3550](#3550) [#3568](#3568) [#3568](#3568)
Copy link

🎉 This issue has been resolved in version 5.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _feedback.altTitle values from example course
6 participants