-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Improvement of tests script to allow param passing (Issue/3472) #3478
Conversation
Note on this - I had considered creating a 'utils' folder and splitting out some functions to a testHelpers file but felt it was potentially a step too far for this PR and also something worth getting peoples thoughts on. I'll happily add this or extend from this branch and do that if it is desired. @oliverfoster Any thoughts there? |
I think it's a waste of time and space unless the functions are going to be used elsewhere. |
… passing spec if not blank
Hi @oliverfoster thanks for your feedback on this. Do you feel the |
I imagine it's only going to be used when writing tests, to specify which tests to run. Is there any other use-case so far? |
No I think thats all. I feel if we meet any use cases in the future we can amend to meet 🤷♂️ Thanks for the approval 👍 |
🎉 This PR is included in version 5.33.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Addresses part 1 and part 2 of #3472