Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding a pagehide listener to cover bases when unload becomes deprecated #125

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: Adding a pagehide listener to cover bases when unload becomes deprecated #125

merged 1 commit into from
Nov 15, 2023

Conversation

cahirodoherty-learningpool
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool commented Nov 14, 2023 •
edited
Loading

Partly fixes FW3481

Fix

  • Added a 'pagehide' listener to backup the soon-to-be-deprecated 'unload' event

joe-allen-89
joe-allen-89 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 7ed0088 into master Nov 15, 2023
1 check passed
@joe-allen-89 joe-allen-89 deleted the unloadDeprecation branch November 15, 2023 11:27
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@semantic-release-bot
Chore(release): 1.1.5 [skip ci]
641f0b0 
## [1.1.5](v1.1.4...v1.1.5) (2023-11-15)

### fix

* Adding a pagehide listener to cover bases when unload becomes deprecated (#125) ([7ed0088](7ed0088)), closes [#125](#125)

### Fix

* Version bump for PR 125 ([f28185d](f28185d))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@eleanor-heath eleanor-heath Awaiting requested review from eleanor-heath

@lemmyadams lemmyadams Awaiting requested review from lemmyadams

Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation of unload event in google chrome
4 participants
@cahirodoherty-learningpool @oliverfoster @ethan-lp @joe-allen-89