Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aria-labelledby added to matching dropdown to read out dropdown label/question (fixes #190) #191

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix: aria-labelledby added to matching dropdown to read out dropdown label/question (fixes #190) #191

merged 1 commit into from
Jul 24, 2024

Conversation

joe-allen-89
Copy link
Contributor

#190

Fix

@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@joe-allen-89 joe-allen-89 linked an issue Jul 12, 2024 that may be closed by this pull request
Should drop downs read the label when opened? #190
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better experience thanks @joe-allen-89. Works as expected testing with voiceOver on Mac 👍

@kirsty-hames kirsty-hames merged commit aa70a3f into master Jul 24, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/190 branch July 24, 2024 13:58
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@semantic-release-bot
Chore(release): 7.4.4 [skip ci]
fa85ae9 
## [7.4.4](v7.4.3...v7.4.4) (2024-07-24)

### Fix

* aria-labelledby added to matching dropdown (fixes #190) (#191) ([aa70a3f](aa70a3f)), closes [#190](#190) [#191](#191)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should drop downs read the label when opened?
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool