Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove unnecessary properties for tile/grid layout (fixes #314) #323

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Fix: Remove unnecessary properties for tile/grid layout (fixes #314) #323

merged 6 commits into from
Oct 15, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Oct 3, 2024 •
edited
Loading

Fix #314

Fix

  • Ensures that the _graphic property on the main component is not required when using the tile / grid layout.
  • Update example.json to remove unnecessary properties for the tile / grid layout: _top, _left, and _imageAlignment for each item.
  • Update example.json to add clarity between the different layout types and to add more realistic image file names.
  • Update README.md to add notes about tile/grid properties.

@swashbuck swashbuck self-assigned this Oct 3, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks

@oliverfoster oliverfoster merged commit 14d062c into master Oct 15, 2024
@oliverfoster oliverfoster deleted the issue/314 branch October 15, 2024 13:11
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
Chore(release): 6.14.2 [skip ci]
4b780a0 
## [6.14.2](v6.14.1...v6.14.2) (2024-10-15)

### Fix

* Remove unnecessary properties for tile/grid layout (fixes #314) (#323) ([14d062c](14d062c)), closes [#314](#314) [#323](#323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Framework: Required fields for tile layout
5 participants
@swashbuck @kirsty-hames @cahirodoherty-learningpool @ethan-lp @oliverfoster