Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python/ru-ru] Corrections for Russian localization #4389

Merged
merged 6 commits into from
Apr 24, 2024
Merged

[python/ru-ru] Corrections for Russian localization #4389

merged 6 commits into from
Apr 24, 2024

Conversation

ademaro
Copy link
Contributor

@ademaro ademaro commented May 14, 2022 •
edited
Loading

  • I solemnly swear that this is all original content of which I am the original author
  • Pull request title is prepended with [language/lang-code] (example [python/fr-fr] or [java/en])
  • Pull request touches only one file (or a set of logically related files with similar changes made)
  • Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)
  • If you've changed any part of the YAML Frontmatter, make sure it is formatted according to CONTRIBUTING.md
    • Yes, I have double-checked quotes and field names!

@ademaro ademaro requested a review from Menelion as a code owner May 14, 2022 15:38
@ademaro
Copy link
Contributor Author

ademaro commented Dec 21, 2022

@Menelion Is there anything else you need to get PR accepted?

@ademaro
Copy link
Contributor Author

ademaro commented Feb 11, 2024

@mribeirodantas, maybe you can help accept this PR?

verhovsky
verhovsky reviewed Apr 3, 2024
View reviewed changes
ru-ru/python-ru.html.markdown Outdated
Comment on lines 488 to 487
pass # pass — это просто отсутствие оператора. Обычно здесь происходит восстановление после ошибки.
pass # pass — это просто отсутствие оператора. Обычно здесь происходит исправление ошибки.
Copy link
Collaborator

@verhovsky verhovsky Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы оставил как было, в except исправлять ошибки это большая редкость.

ademaro and others added 3 commits April 24, 2024 20:02
@ademaro
Copy link
Contributor Author

ademaro commented Apr 24, 2024

@verhovsky, логично. Спасибо за подробное ревью.

@verhovsky verhovsky merged commit a41ac72 into adambard:master Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verhovsky verhovsky verhovsky left review comments

@Menelion Menelion Awaiting requested review from Menelion Menelion is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademaro @verhovsky