Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add PHY coded support to Adafruit API #786

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n-snyder
Copy link

This change attempts to update the Bluefruit52 library to enable access to a few of Nordic's API settings with the hope of using BLE long-range advertising (PHY coded). I applied these changes to an Adafruit ItsyBitsy nRF52840 Express board, attempted to advertise, and was unsuccessful with having a BT sniffer pick up the advertisements. Therefore, please review the changes well and let me know if there is an error.

I am using a second Adafruit ItsyBitsy nRF52840 Express with Wireshark to serve as the sniffer. The nRF Sniffer plug-in is set to pick up PHY coded advertisements. I share this because I cannot isolate the root cause with the hardware that I have available:

  1. The board may not be capable of PHY coded advertisements and/or sniffing
  2. nRF's software may not be correctly sniffing PHY coded
  3. The code in this pull request is wrong
  4. My application's use of the API is wrong.

If someone has enabled this functionality on one of the boards, please consider sharing the settings used.

Copy link
Contributor

@mharper mharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n-snyder I don't think that abbreviating events to evts really buys you anything here. Might as well just spell it out for clarity.

@hathach
Copy link
Member

hathach commented Nov 30, 2023

currently, I don't have the bandwidth to test and update this PR. Since it is not working yet, I convert it to draft, feel free to mark ready when it works as expected.

@hathach hathach marked this pull request as draft November 30, 2023 05:41
@n-snyder
Copy link
Author

n-snyder commented Dec 1, 2023

@hathach, with further testing, this is not working yet. It is a step in the right direction, but the primary physical layer is still advertising at 1 M, rather than coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants