Bug: 980 (Cannot read properties of undefined (reading 'isOpen') in MediaImageCarousel.vue)

[mattburnett-repo]

Added if statement to watch(route) so that closeModal() is called only when modals are present.

Contributor checklist

• This pull request is on a separate branch and not the main branch

---

Description

This PR attempts to correct an error that occurs when a user navigates the app and there are no modals in the modal Pinia store. It is part of a larger effort to make the modal implementation more consistent.

Related issue

• TypeError: Cannot read properties of undefined (reading 'isOpen') in MediaImageCarousel.vue #980

[github-actions]

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

• The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

• The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[netlify]

✅ Deploy Preview for activist-org ready!

Name	Link
🔨 Latest commit	e377b89
🔍 Latest deploy log	https://app.netlify.com/sites/activist-org/deploys/66fbbd1061bd4c00089cb997
😎 Deploy Preview	https://deploy-preview-981--activist-org.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[andrewtavis]

Thanks for the quick fix here, @mattburnett-repo! Let's be in touch on a call later to look into this :)