Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#835 Close Safari buttom bar for fullscreen map #979

Closed
wants to merge 6 commits into from

Conversation

andrewtavis
Copy link
Member

Contributor checklist


Description

Sending along a PR so this can be checked on Mobile via Netlify previews. Goal is that when the user clicks fullscreen on the map that the bottom bar on Safari will automatically close. Without this, on smaller iPhones the map can be a bit small in the fullscreen mode.

Related issue

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 8b17a0e
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/66f93b1ecbe0800008f20cbf
😎 Deploy Preview https://deploy-preview-979--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis
Copy link
Member Author

Closing this after trying a ton of options. Doesn't look like this is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant