Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a password tooltip component #481

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Created a password tooltip component #481

merged 1 commit into from
Oct 21, 2023

Conversation

ahmedy00
Copy link
Contributor

@ahmedy00 ahmedy00 commented Oct 19, 2023

Contributor checklist


Description

Related issue

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit a2fdd60
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/65315cd0eda14a00087196fa
😎 Deploy Preview https://deploy-preview-481--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahmedy00 ahmedy00 marked this pull request as draft October 19, 2023 16:44
@ahmedy00 ahmedy00 marked this pull request as ready for review October 19, 2023 16:45
@andrewtavis andrewtavis self-requested a review October 19, 2023 16:47
@andrewtavis
Copy link
Member

Thanks for this, @ahmedy00! Looking forward to checking it out :) :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 20, 2023
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've said it once and I gotta say it again @ahmedy00 that I'm really glad you jumped on the sign up/in flow and have been so active here. This PR is a thing of beauty ✨😊 I'll do some minor edits to format the tooltip a bit so it doesn't take up as much of the screen. Aside from that, this is perfect :)

Thank you!

@andrewtavis andrewtavis merged commit c591b58 into activist-org:main Oct 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants