Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Throttling #421

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Rate Throttling #421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f71e13a
Rate Throttling
sulabhkatila Oct 8, 2023
b661711
Merge branch 'main' into api
andrewtavis Oct 11, 2023
f7b1a6d
Revert tests - WIP in another issue
andrewtavis Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion backend/backend/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

INSTALLED_APPS = [
"rest_framework",
"rest_framework.authtoken",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this for user-based throttling? I think we can get rid of the authtoken and address this in a seperate issue.

"django.contrib.admin",
"django.contrib.auth",
"django.contrib.contenttypes",
Expand Down Expand Up @@ -97,7 +98,15 @@
"PASSWORD": DATABASE_PASSWORD,
"HOST": DATABASE_HOST,
"PORT": DATABASE_PORT,
}
},
"test": {
"ENGINE": "django.db.backends.postgresql",
"NAME": "test_" + DATABASE_NAME,
"USER": DATABASE_USER,
"PASSWORD": DATABASE_PASSWORD,
"HOST": DATABASE_HOST,
"PORT": DATABASE_PORT,
},
}
Comment on lines +101 to 110
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say for now, we do not need to explicitly create a test database, since Django does that by default. Here are the paragraphs from the docs:

Tests that require a database (namely, model tests) will not use your “real” (production) database. Separate, blank databases are created for the tests.
...
The default test database names are created by prepending test_ to the value of each NAME in DATABASES.

We might start with the TEST key inside the database. But we will address that in the issue #432.



Expand Down Expand Up @@ -146,6 +155,11 @@
SECRET_KEY = get_random_secret_key()

REST_FRAMEWORK = {
"DEFAULT_THROTTLE_CLASSES": [
"rest_framework.throttling.AnonRateThrottle",
"rest_framework.throttling.UserRateThrottle",
],
"DEFAULT_THROTTLE_RATES": {"anon": "7/min", "user": "10/min"},
"DEFAULT_SCHEMA_CLASS": "drf_spectacular.openapi.AutoSchema",
"DEFAULT_PAGINATION_CLASS": "rest_framework.pagination.PageNumberPagination",
"PAGE_SIZE": 20,
Expand Down
Loading