-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding finshark icon #916
adding finshark icon #916
Conversation
Hi @robbanp , The changes are good to go but we need you to rebase your branch Mondido:finshark_icon with activemerchant/master to resolve the conflicts. After the rebase is done, we will be able to merge your changes. Thanks |
resubmit
updated
updated
updated
updated
Thanks, it's rebased! |
Hi @robbanp , not sure why we have too many commits in this PR, could you please rebase again from master and push your the changes again. Thanks |
will remake a clean PR |
Why are you adding this icons?
I'm adding/updating this icon(s) because our payment gateway support also Finshark payments
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?