Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pointspay and Flying Blue+ icons #1202

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

logeecom
Copy link
Contributor

Why are you adding this icons?

I'm adding/updating this icon(s) because this is a new payment gateway for Shopify - approved under Partner account Pointspay.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines: https://pointspay.com/

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Screenshots of the icons along side the example Visa icon

pointspay
flyingblue

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Payment partnership team

What's the expected date of this change to deploy on Shopify?
As soon as possible

Copy link
Collaborator

@nickagin nickagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission. Please run both icons through svggo to reduce filesize.

@logeecom
Copy link
Contributor Author

logeecom commented Aug 5, 2024

Hi @nickagin, the icons have been updated. Do you have ETA when the changes will be merged?

@logeecom logeecom requested a review from nickagin August 15, 2024 07:52
@logeecom logeecom closed this Aug 30, 2024
@logeecom logeecom reopened this Aug 30, 2024
@logeecom
Copy link
Contributor Author

logeecom commented Sep 4, 2024

Hi @nickagin, the icons have been updated. Do you have ETA when the changes will be merged?

@dannye0231 dannye0231 merged commit bbe2e2a into activemerchant:master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants