Handle ISO-8859-1 encoded strings in Notification #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
paypal-ipn-encoding
branch
2 times, most recently
from
9e2b952
to
d29b874
Compare
|
@BranLiang could you have a look into this please? |
Paypal tend to send data encoded in ISO-8859-1, we should return only valid UTF-8 encoded strings.
casperisfine
force-pushed
the
paypal-ipn-encoding
branch
from
d29b874
to
503cb8a
Compare
|
Not too sure what is going on with the remaining failure, I can't reproduce it locally. |
|
Ok, by making |
adrianna-chang-shopify
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
LGTM 👍 I believe it's the development dependency on rails that's causing compat issues on Rails edge? 🤔 I can't see that we need a full dependency on rails (activesupport / actionpack / actionview should be sufficient), can we just remove that?
And while we're at it, would it make sense to add Ruby 3 to the CI matrix?
|
I'd rather keep the changes as small as possible given I don't have merge permissions on that repo. |
shopify-shipit-activemerchant
bot
temporarily deployed
to
rubygems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paypal tend to send data encoded in ISO-8859-1, we should return only valid UTF-8 encoded strings.