Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Update IPNs URL #347

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

akiko-pusu
Copy link
Contributor

Thanks for all!
This pull request is not a bug fix, but a proposal.

Reason

Now Paypal recommends the use of new endpoints based on 'ipnpb.paypal.com'.

Ref:

What happens in this situation?

We can still use the URL https://www.sandbox.paypal.com/cgi-bin/webscr and https://www.paypal.com/cgi-bin/webscr without any difference in terms of API features.

But following the document that I wrote above, www.paypal.com returns the response under the dynamic IP address.
If some requirements exist such as restriction for the source/destination IP address, ''ipnpb.paypal.com'' based URL is better.

Of course, we can change the URL by ourselves by overwriting the variable like this:

# production_url is customizable because of "mattr_accessor" statement.
OffsitePayments::Integrations::Paypal.production_url = 'https://ipnpb.paypal.com/cgi-bin/webscr'

Other proposals

If this PR is not acceptable, I think updating README to introduce how to customize the URL like above.

NOTE:

Before submitting this pull request, I posted the one to fix the CI failure.
I wish either one would be of help.

@JasonBarnabe
Copy link
Contributor

Not sure if it's a temporary issue, but starting today calls to OffsitePayments::Integrations::Paypal::Notification#acknowledge in sandbox mode (using https://www.sandbox.paypal.com/cgi-bin/webscr) are failing as that's doing a 301 to https://www.sandbox.paypal.com/us/cgi-bin/wapapp?cmd=_wapapp-homepage.

Updating the URL to https://ipnpb.sandbox.paypal.com/cgi-bin/webscr as this PR does fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants