Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rubocop 1.26.0 #5325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Rubocop 1.26.0 #5325

wants to merge 3 commits into from

Conversation

almalee24
Copy link
Contributor

Update done using bundle exec rubocop -a

@almalee24 almalee24 requested review from a team and removed request for a team November 5, 2024 19:09
@almalee24 almalee24 requested a review from a team November 5, 2024 19:14
Copy link
Contributor

@DustinHaefele DustinHaefele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, but overall looks good.

@@ -34,4 +34,5 @@ Gem::Specification.new do |s|
s.add_development_dependency('rake')
s.add_development_dependency('test-unit', '~> 3')
s.add_development_dependency('thor')
s.metadata['rubygems_mfa_required'] = 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this metadata line doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm thinking I should also disable this one

.rubocop.yml Outdated Show resolved Hide resolved
lib/active_merchant/billing/compatibility.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@DustinHaefele DustinHaefele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants