-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rubocop 1.26.0 #5325
base: master
Are you sure you want to change the base?
Update Rubocop 1.26.0 #5325
Conversation
37d201b
to
480e752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments, but overall looks good.
activemerchant.gemspec
Outdated
@@ -34,4 +34,5 @@ Gem::Specification.new do |s| | |||
s.add_development_dependency('rake') | |||
s.add_development_dependency('test-unit', '~> 3') | |||
s.add_development_dependency('thor') | |||
s.metadata['rubygems_mfa_required'] = 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this metadata line doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'm thinking I should also disable this one
480e752
to
b74cded
Compare
Update done using bundle exec rubocop -a
b74cded
to
aca3de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the updates.
Update done using bundle exec rubocop -a