Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write events test suite #181

Closed
wants to merge 35 commits into from
Closed

Write events test suite #181

wants to merge 35 commits into from

Commits on Apr 18, 2021

  1. Add skeleton event tests

    @shravanhariharan2
    shravanhariharan2 committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    c12ac20 View commit details
    Browse the repository at this point in the history

  2. Add missing await to EventService::createEvent

    @shravanhariharan2
    shravanhariharan2 committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    ef89fa3 View commit details
    Browse the repository at this point in the history

  3. Add rest of CRUD operation tests

    @shravanhariharan2
    shravanhariharan2 committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    bc43ff9 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Add storage utils for mocking images to upload

    @shravanhariharan2
    shravanhariharan2 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ce6dcb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Add event feedback fakes

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    290c828 View commit details
    Browse the repository at this point in the history

  2. Add empty file check for storage test utils

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    159d169 View commit details
    Browse the repository at this point in the history

  3. Refactor EventFactory to fake past, ongoing, and future events easily

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    bbaedc2 View commit details
    Browse the repository at this point in the history

  4. Remove unused validator in feedback

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6a9b5ae View commit details
    Browse the repository at this point in the history

  5. Finish writing preliminary event tests

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    74db6ba View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into tests/events

    @shravanhariharan2
    shravanhariharan2 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    d2fd439 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Update tests/event.test.ts 

    Co-authored-by: Sumeet Bansal <[email protected]>
    @shravanhariharan2 @sumeet-bansal
    shravanhariharan2 and sumeet-bansal authored May 4, 2021
    Configuration menu
    Copy the full SHA
    8d7623d View commit details
    Browse the repository at this point in the history

  2. Refactor EventFactory fake methods

    @shravanhariharan2
    shravanhariharan2 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    a264273 View commit details
    Browse the repository at this point in the history

  3. Inline all error messages that are only used once

    @shravanhariharan2
    shravanhariharan2 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    caa4f92 View commit details
    Browse the repository at this point in the history

  4. Fix small event test nits

    @shravanhariharan2
    shravanhariharan2 committed May 4, 2021
    Configuration menu
    Copy the full SHA
    a33bcd0 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge branch 'master' into tests/events

    @shravanhariharan2
    shravanhariharan2 committed May 6, 2021
    Configuration menu
    Copy the full SHA
    fcc0e4a View commit details
    Browse the repository at this point in the history

  2. Change controller params in test to match updated validation format

    @shravanhariharan2
    shravanhariharan2 committed May 6, 2021
    Configuration menu
    Copy the full SHA
    e56e157 View commit details
    Browse the repository at this point in the history

  3. Move asserts next to data fetches

    @shravanhariharan2
    shravanhariharan2 committed May 6, 2021
    Configuration menu
    Copy the full SHA
    cc6f83b View commit details
    Browse the repository at this point in the history

  4. Refactor EventFactory random time generation

    @shravanhariharan2
    shravanhariharan2 committed May 6, 2021
    Configuration menu
    Copy the full SHA
    8ef3ea1 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Merge branch 'master' into tests/events

    @shravanhariharan2
    shravanhariharan2 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5b3fa0c View commit details
    Browse the repository at this point in the history

  2. Switch to non-deprecated hexadecimal generation

    @shravanhariharan2
    shravanhariharan2 committed May 18, 2021
    Configuration menu
    Copy the full SHA
    6e55d48 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. mocking with jest sucks

    @shravanhariharan2
    shravanhariharan2 committed May 21, 2021
    Configuration menu
    Copy the full SHA
    2f8c3b4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Add 'update event' tests

    @shravanhariharan2
    shravanhariharan2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    2529a86 View commit details
    Browse the repository at this point in the history

  2. Make event patches fields explicitly optional in validation (they wer… 

    …e optional before but implicitly)
    @shravanhariharan2
    shravanhariharan2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    28a55ca View commit details
    Browse the repository at this point in the history

  3. Allow mocked services to be injected into controllers

    @shravanhariharan2
    shravanhariharan2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    ede38bf View commit details
    Browse the repository at this point in the history

  4. Remove redundant type

    @shravanhariharan2
    shravanhariharan2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    539d35e View commit details
    Browse the repository at this point in the history

  5. Switch mocking aws-sdk to StorageService using ts-mockito

    @shravanhariharan2
    shravanhariharan2 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    18a952c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Merge branch 'master' into tests/events

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    342dcb5 View commit details
    Browse the repository at this point in the history

  2. Move ts-mockito from dep to devDep

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    a70a68e View commit details
    Browse the repository at this point in the history

  3. Remove singleton behavior from ControllerFactory

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    cc1694b View commit details
    Browse the repository at this point in the history

  4. Move controllers/index.ts -> ControllerFactory.ts

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    9b51a89 View commit details
    Browse the repository at this point in the history

  5. Move createEventFeedback from FeedbackFactory to EventFactory

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    3ecb774 View commit details
    Browse the repository at this point in the history

  6. Move fakeOngoingEvent start duration forward 30 minutes

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    2c5ca2a View commit details
    Browse the repository at this point in the history

  7. Tighten error handling to match constraint in test

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    a88706e View commit details
    Browse the repository at this point in the history

  8. Lint

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    98023da View commit details
    Browse the repository at this point in the history

  9. Add get call to event cover test to ensure cover is persisted

    @shravanhariharan2
    shravanhariharan2 committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    298f5f3 View commit details
    Browse the repository at this point in the history