Change checkin args #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Stuart6557
commented
Oct 14, 2023
Stuart6557
commented
- Changed 'now' parameter to 'public', false by default
- Removed filtering for ongoing events only
alexzhang1618
requested changes
Oct 14, 2023
src/Client.ts
Outdated
Comment on lines
48
to
55
| 'GUILDS', | ||
| 'GUILD_INTEGRATIONS', | ||
| 'GUILD_WEBHOOKS', | ||
| 'GUILD_MESSAGES', | ||
| 'GUILD_MEMBERS', | ||
| 'DIRECT_MESSAGES', | ||
| 'GUILD_MESSAGE_REACTIONS', | ||
| 'DIRECT_MESSAGE_REACTIONS', | ||
| GatewayIntentBits.Guilds, | ||
| GatewayIntentBits.GuildIntegrations, | ||
| GatewayIntentBits.GuildWebhooks, | ||
| GatewayIntentBits.GuildMessages, | ||
| GatewayIntentBits.DirectMessages, | ||
| GatewayIntentBits.GuildMessageReactions, | ||
| GatewayIntentBits.DirectMessageReactions, |
There was a problem hiding this comment.
Why are these changing in this PR? Does it work without these changes?
src/commands/Checkin.ts
Outdated
| * the widescreen slide QR (true). | ||
| * This Command DM's the caller the checkin code and Express Checkin link for any current and | ||
| * upcoming events in today's timeframe. Optional argument `public` makes the embed with the | ||
| * checkin codes be returned in the same chat as the Command message instead of DMs. Optinoal |
There was a problem hiding this comment.
nit:
Suggested change
| * checkin codes be returned in the same chat as the Command message instead of DMs. Optinoal | |
| * checkin codes be returned in the same chat as the Command message instead of DMs. Optional |
src/commands/Checkin.ts
Outdated
| @@ -40,7 +40,7 @@ export default class Checkin extends Command { | |||
| boardRequired: true, | |||
| enabled: true, | |||
| description: | |||
| "Sends a private message with all check-in codes from today's events. Calling with `now` argument sends public embed of checkin code if any events are now live!", | |||
| "Sends a private message with all check-in codes from today's events. Calling with `public` argument sends public embed of checkin code.", | |||
There was a problem hiding this comment.
Maybe here it should specify that public sends in the current channel instead of via DM?
src/commands/Checkin.ts
Outdated
| @@ -85,10 +86,6 @@ export default class Checkin extends Command { | |||
| // | |||
| // We need two sets of arrays for "checkin": | |||
There was a problem hiding this comment.
Can update this comment and related ones: we don't need two sets of arrays for "checkin" anymore
src/config/config.ts
Outdated
Comment on lines
12
to
19
| 'GUILDS', | ||
| 'GUILD_INTEGRATIONS', | ||
| 'GUILD_WEBHOOKS', | ||
| 'GUILD_MESSAGES', | ||
| 'GUILD_MEMBERS', | ||
| 'DIRECT_MESSAGES', | ||
| 'GUILD_MESSAGE_REACTIONS', | ||
| 'DIRECT_MESSAGE_REACTIONS', | ||
| GatewayIntentBits.Guilds, | ||
| GatewayIntentBits.GuildIntegrations, | ||
| GatewayIntentBits.GuildWebhooks, | ||
| GatewayIntentBits.GuildMessages, | ||
| GatewayIntentBits.DirectMessages, | ||
| GatewayIntentBits.GuildMessageReactions, | ||
| GatewayIntentBits.DirectMessageReactions, |
There was a problem hiding this comment.
Same question as in Client.ts
src/types/.DS_Store
Outdated
There was a problem hiding this comment.
This file should be removed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.