Matcha groups size #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farisashai
commented
May 29, 2023
src/utils/Logger.ts
Outdated
| @@ -25,7 +25,7 @@ export default createLogger({ | |||
| format: json(), | |||
| transports: [ | |||
| new Transports.Console({ | |||
| level: 'debug', | |||
| level: 'error', | |||
alexzhang1618
requested changes
May 30, 2023
src/commands/Matcha.ts
Outdated
| @@ -104,17 +107,31 @@ export default class Matcha extends Command { | |||
| const shuffledMembersList = Matcha.shuffle(users); | |||
| const memberPairings = []; | |||
|
|
|||
| const groupsize = interaction.options.getInteger('groupsize', true); | |||
| Logger.error(`/matcha - ready to match ${shuffledMembersList}`); | |||
There was a problem hiding this comment.
why is this Logger.error here? Is this a logging statement we can remove?
src/commands/Matcha.ts
Outdated
| } | ||
| memberPairings.push(pairedMembers); | ||
| } | ||
|
|
||
| Logger.error(`/matcha - matching worked? ${memberPairings}`); |
There was a problem hiding this comment.
again here, i don't think we need this logging anymore ^
src/commands/Matcha.ts
Outdated
Comment on lines
203
to
210
| if (groupsize <= 1) { | ||
| await super.edit(interaction, { | ||
| content: 'You need to enter an integer greater than 1 otherwise your only friend will be yourself :angry:', | ||
| components: [], | ||
| ephemeral: true, | ||
| }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Nit: I think we can rewrite this error message to be more in line with what our other messages look like
Instead of integer, we can say "group size", and also add some punctuation
**/matcha** needs a group size greater than 1! Otherwise, your only friend will be yourself! :rage:
src/commands/Matcha.ts
Outdated
Comment on lines
114
to
128
| const extraMembers = shuffledMembersList.length % groupsize; | ||
| const numGroups = Math.floor(shuffledMembersList.length / groupsize); | ||
| Logger.error(`/matcha - numGroups ${numGroups}, extraMembers: ${extraMembers} groupsize ${groupsize}`); | ||
| if (extraMembers !== 0) { | ||
| // If length % size is off add people to the first group or first n groups | ||
| // for one group remaining add all extras | ||
| if (numGroups === 1) { | ||
| pairedMembers = shuffledMembersList.splice(0, shuffledMembersList.length); | ||
| Logger.error(`/matcha - pair ${pairedMembers}`); | ||
| } | ||
| // otherwise, disperse extra people across groupss | ||
| else { | ||
| const addedToGroup = Math.floor(extraMembers / numGroups); | ||
| pairedMembers = shuffledMembersList.splice(0, groupsize + addedToGroup); | ||
| } |
There was a problem hiding this comment.
Nit: I think we can make this code more clear by breaking the code out into a helper function (maybe splitIntoGroups()?)
Additionally, I think we need to consider edge cases here:
- What if the group size is 3 and we have 5 total members? I think this code makes a pair of 4 and leaves the last person lonely
alexzhang1618
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a field to the matcha command for group size. The groupsize is minimum group size. If there is not a clean split, it will add across multiple groups. This can lead to larger groups than intended.