Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create readme.md #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create readme.md #85

wants to merge 1 commit into from

Conversation

avi-01
Copy link
Contributor

@avi-01 avi-01 commented Apr 3, 2019

The extension is published on chrome web store.

Copy link
Member

@sarthakgupta072 sarthakgupta072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much duration you have set? I mean how much history does it keep track of? 1 day?

@avi-01
Copy link
Contributor Author

avi-01 commented Apr 4, 2019 via email

@sarthakgupta072
Copy link
Member

Actually, we want you to consider a fixed duration. Like a week, or month, or year maybe. Please try to do that.

@avi-01
Copy link
Contributor Author

avi-01 commented Apr 4, 2019 via email

@sarthakgupta072
Copy link
Member

You can try either of the approaches. Although, if you allow the user to set the time duration, that will be a much better project.

Duration will be decided by user or we provided a fixed duration of time?

On Thu, Apr 4, 2019, 5:42 PM Sarthak Gupta @.***> wrote: Actually, we want you to consider a fixed duration. Like a week, or month, or year maybe. Please try to do that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/As5l-DdzgB1oG0K-YAhwsKeEAmHS-6TXks5vdewegaJpZM4cbLrN .

@avi-01
Copy link
Contributor Author

avi-01 commented Apr 4, 2019 via email

@sarthakgupta072
Copy link
Member

I think you are getting my point wrong.

The extension should be able to tell the site visits of a particular site from the past month. Your extension is starting afresh from the installation date. Try to make it do that. It should be able to read your browsers history.

@avi-01
Copy link
Contributor Author

avi-01 commented Apr 4, 2019 via email

@sarthakgupta072
Copy link
Member

Oh. We need to also get the data from past. Before installation.

On Thu, Apr 4, 2019, 9:56 PM Sarthak Gupta @.***> wrote: I think you are getting my point wrong. The extension should be able to tell the site visits of a particular site from the past month. Your extension is starting afresh from the installation date. Try to make it do that. It should be able to read your browsers history. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/As5l-DOAKq5t7Pjw8evaYnU8MKaex1yMks5vdieagaJpZM4cbLrN .

Yes... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants