-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create readme.md #85
base: master
Are you sure you want to change the base?
Create readme.md #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much duration you have set? I mean how much history does it keep track of? 1 day?
It track the record from the time of installation. And it doesn't expire. So
data from start is stored in it without any expiration.
…On Thu, Apr 4, 2019, 1:30 PM Sarthak Gupta ***@***.***> wrote:
***@***.**** commented on this pull request.
How much duration you have set? I mean how much history does it keep track
of? 1 day?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/As5l-NWYWPfCQLJC-p78xIzyIOVhWQn4ks5vdbEFgaJpZM4cbLrN>
.
|
Actually, we want you to consider a fixed duration. Like a week, or month, or year maybe. Please try to do that. |
Duration will be decided by user or we provided a fixed duration of time?
…On Thu, Apr 4, 2019, 5:42 PM Sarthak Gupta ***@***.***> wrote:
Actually, we want you to consider a fixed duration. Like a week, or month,
or year maybe. Please try to do that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/As5l-DdzgB1oG0K-YAhwsKeEAmHS-6TXks5vdewegaJpZM4cbLrN>
.
|
You can try either of the approaches. Although, if you allow the user to set the time duration, that will be a much better project.
|
I have updated the visit counter now it track record of only a month.
After that it reset itself
…On Thu, Apr 4, 2019, 5:51 PM Sarthak Gupta ***@***.***> wrote:
You can try either of the approaches. Although, if you allow the user to
set the time duration, that will be a much better project.
Duration will be decided by user or we provided a fixed duration of time?
… <#m_-2196616925654244002_>
On Thu, Apr 4, 2019, 5:42 PM Sarthak Gupta ***@***.***> wrote: Actually,
we want you to consider a fixed duration. Like a week, or month, or year
maybe. Please try to do that. — You are receiving this because you authored
the thread. Reply to this email directly, view it on GitHub <#85 (comment)
<#85 (comment)>>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/As5l-DdzgB1oG0K-YAhwsKeEAmHS-6TXks5vdewegaJpZM4cbLrN
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/As5l-MoWWzC3FS6zNRw3cIXYFWjDg9PPks5vde5TgaJpZM4cbLrN>
.
|
I think you are getting my point wrong. The extension should be able to tell the site visits of a particular site from the past month. Your extension is starting afresh from the installation date. Try to make it do that. It should be able to read your browsers history. |
Oh. We need to also get the data from past. Before installation.
…On Thu, Apr 4, 2019, 9:56 PM Sarthak Gupta ***@***.***> wrote:
I think you are getting my point wrong.
The extension should be able to tell the site visits of a particular site
from the past month. Your extension is starting afresh from the
installation date. Try to make it do that. It should be able to read your
browsers history.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/As5l-DOAKq5t7Pjw8evaYnU8MKaex1yMks5vdieagaJpZM4cbLrN>
.
|
Yes... :) |
The extension is published on chrome web store.