Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variant which sets up 2FA with devise #77

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

eoinkelly
Copy link
Contributor

@eoinkelly eoinkelly commented Apr 11, 2020

Current status

WIP. This branch can be used as inspiration for a devise MFA feature. The design doc included in this PR is particularly useful for understanding the feature.

Background

These changes were initially sketched in ackama/rails-template-demo-devise-2fa#11 and refined in some real client apps. Hat tip to @joshmcarthur who greatly improved my first pass at this. Fixes #61

TODO

  • Be consistent in whether we describe this as 2FA or MFA
  • Decide whether this variant should create a seed user for easy testing of sign-in and sign-out (decided against doing this)
  • Fix all TODO items in the code
  • Generate tests for all code added by this variant

@eoinkelly eoinkelly changed the base branch from master to main July 25, 2020 22:22
@eoinkelly
Copy link
Contributor Author

The basics are in this now but we need to add:

  • Screens for managing OTP for your user
  • A screen for backup codes (not sure how hard this is to do)

My goal here is that this should generate everything you need except CSS styling for the feature

@trevh-ack trevh-ack self-requested a review August 5, 2020 21:38
@trevh-ack trevh-ack self-assigned this Aug 5, 2020
@eoinkelly eoinkelly removed the request for review from trevh-ack May 28, 2021 02:43
@eoinkelly
Copy link
Contributor Author

I now think this is big enough to be a whole separate template so I'm going to close this.

@eoinkelly eoinkelly closed this May 28, 2021
@eoinkelly eoinkelly reopened this Mar 4, 2022
@eoinkelly
Copy link
Contributor Author

This work has to be paused until devise-two-factor supports Rails 7. I'm trying to help make that happen on devise-two-factor/devise-two-factor#206

@eoinkelly
Copy link
Contributor Author

eoinkelly commented Jul 9, 2022

See ackama/rails-template-demo-devise-2fa#1 for progress on this feature.

Edit: this is outdated, latest changes are in this PR now

@eoinkelly eoinkelly changed the title Add a variant which sets up 2FA (Two Factor Auth) with devise [DRAFT] Add a variant which sets up 2FA with devise [WIP] Jul 9, 2022
@eoinkelly eoinkelly added the WIP Work in progress label Oct 14, 2022
@eoinkelly eoinkelly changed the title Add a variant which sets up 2FA with devise [WIP] Add a variant which sets up 2FA with devise Oct 14, 2022
@robotdana
Copy link
Contributor

copy improvements from another project which doesn't need js and is instead an actual 2-step process with separate pages

@eoinkelly
Copy link
Contributor Author

I have copied the files from ackama/rails-template-demo-devise-2fa#11 which incorporates changes made on client projects. This PR is still very WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a 2FA (Two Factor Auth) with Devise variant
4 participants