Enable class and module children cop #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotdana
force-pushed
the
enable-class-and-module-children-cop
branch
3 times, most recently
from
fcbe6b7
to
3c2b0fb
Compare
lukeify
approved these changes
Jul 11, 2024
G-Rath
force-pushed
the
enable-class-and-module-children-cop
branch
2 times, most recently
from
095ae5e
to
72f5be1
Compare
there was some discussion in the ruby guild meeting and in slack https://ackama.slack.com/archives/CTXRR56JD/p1715895284411699 we eventually agreed it was better for consistency and also for it's a rubocop default and people expect the autocorrect to happen
G-Rath
force-pushed
the
enable-class-and-module-children-cop
branch
from
72f5be1
to
d70a63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rubocop.org/rubocop/cops_style.html#styleclassandmodulechildren
there was some discussion in the ruby guild meeting and in slack
https://ackama.slack.com/archives/CTXRR56JD/p1715895284411699
we eventually agreed it was better for consistency
and also for it's a rubocop default and people expect the autocorrect to happen