Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perl dependencies (& CI) #1205

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Oct 24, 2024

I noticed the LORIS-MRI Docker image was no longer building in CI for #1191. After some investigation, it appears to be because of an update in Module::Pluggable (the first in 9 years !), which some of our required packages depend on (notably DateTime, but also others I think). This PR fixes the issue by pinning the version of Module::Pluggable to version 5.2.

During the investigation of this PR, I also changed our pipeline to use cpan instead of cpanm, which seems to be the recommended package installer by the Perl community. It provides both a much clearer output (no longer literal tens of thousands of lines) and is faster by approximately 5 minutes.

@maximemulder maximemulder force-pushed the 2024-10-24_fix-perl-install branch 6 times, most recently from 42d2b72 to b2388a9 Compare October 24, 2024 18:19
@maximemulder maximemulder added this to the 27.0 milestone Oct 24, 2024
@maximemulder maximemulder marked this pull request as ready for review October 24, 2024 18:49
@maximemulder maximemulder changed the title Fix Perl dependencies CI Fix Perl dependencies (& CI) Oct 24, 2024
@maximemulder maximemulder added the S-Small Size: Small. Simple pull requests that contain little code and should be easy to review label Oct 24, 2024
@maximemulder
Copy link
Contributor Author

Sometimes, you gotta do what you gotta do.

@maximemulder maximemulder merged commit 9810e93 into aces:main Oct 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug S-Small Size: Small. Simple pull requests that contain little code and should be easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant