Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_test.cmake: fix regex #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

run_test.cmake: fix regex #53

wants to merge 1 commit into from

Conversation

barracuda156
Copy link

Fixes: #52

@barracuda156
Copy link
Author

This fix borrowed from: facebook/rocksdb#1231

@barracuda156 barracuda156 mentioned this pull request Jun 18, 2023
Merged
12 tasks
pah
pah suggested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@pah pah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good, but commit is missing a DCO sign-off, see CONTRIBUTING.md

@barracuda156
Copy link
Author

@pah Sorry, I missed your reply. Anyway, apparently sources changed since then, and 3.0.1 does not have that file and does not need this fix either. Should I close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pah pah pah requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail to run with: string sub-command REGEX, mode REPLACE needs at least 6 arguments total to command
2 participants
@barracuda156 @pah