Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2507 - Update auth in readers service #2514

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a bug fix because it fixes the following issue: #2507

What does this do?

This pr updates auth for the readers service with recent updates to auth.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, test files have been updated

Did you document any new/modified feature?

No,

Notes

@felixgateru felixgateru self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.50%. Comparing base (a5059a7) to head (1ddbf37).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sdk/mocks/sdk.go 0.00% 8 Missing ⚠️
readers/api/transport.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
- Coverage   53.62%   51.50%   -2.12%     
==========================================
  Files         332       98     -234     
  Lines       35433    12179   -23254     
==========================================
- Hits        19001     6273   -12728     
+ Misses      14618     5449    -9169     
+ Partials     1814      457    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixgateru felixgateru marked this pull request as ready for review November 9, 2024 08:41
@dborovcanin dborovcanin merged commit 3a02788 into absmach:main Nov 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot read messages from Readers
3 participants